dnoulet/go-guess
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: handle empty candidate trait lists

Browse source 
Return empty JSON arrays from the API and normalize nullable values from older servers before rendering candidate match counts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Daniel Noulet 2026-09-19 21:34:12 +02:00
parent 6969f79015
commit fd06fbbb5d
4 changed files with 36 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
backend/internal/web/mapper/mapper.go
View file

@ -66,9 +66,17 @@ func ParticipantToWeb(value servicemodel.Participant) webmodel.ParticipantRespon
}
func CandidateToWeb(value servicemodel.CandidateMatch) webmodel.CandidateResponse {
matched := value.Matched
if matched == nil {
matched = []string{}
}
missing := value.Missing
if missing == nil {
missing = []string{}
}
return webmodel.CandidateResponse{
Participant: ParticipantToWeb(value.Participant), Score: value.Score,
Matched: value.Matched, Missing: value.Missing,
Matched: matched, Missing: missing,
}
}

7
backend/internal/web/mapper/mapper_test.go
View file

@ -19,3 +19,10 @@ func TestInterviewOmitsReferenceAnswer(t *testing.T) {
t.Fatalf("expected participant-safe code question, got %#v", response)
}
}
func TestCandidateAlwaysUsesJSONArrays(t *testing.T) {
response := CandidateToWeb(servicemodel.CandidateMatch{})
if response.Matched == nil || response.Missing == nil {
t.Fatalf("candidate trait collections must not be nil: %#v", response)
}
}